[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#30207: 27.0.50; [PATCH] other-window-for-scrolling returns window on
From: |
martin rudalics |
Subject: |
bug#30207: 27.0.50; [PATCH] other-window-for-scrolling returns window on daemon frame |
Date: |
Mon, 22 Jan 2018 19:59:47 +0100 |
> I believe this issue and its potential resolution share some ground with
> bug#27210 in that the daemon frame is counterintuitively considered
> visible in the following repeat-until condition in
> Fother_window_for_scrolling:
>
> do
> window = Fnext_window (window, Qnil, Qt);
> while (! FRAME_VISIBLE_P (XFRAME (WINDOW_FRAME (XWINDOW (window))))
> && ! EQ (window, selected_window));
>
> Until a more thorough review of the visibility of the initial daemon
> frame is reached, I propose the attached patch to additionally ignore
> the daemon frame in the aforementioned repeat-until condition. I assume
> the overhead of the additional loop logic and IS_DAEMON invariant is
> negligible compared to the rest of the function.
>
> An alternative approach to the attached patch would be to limit "other
> window scrolling" to frames in the current terminal, as per the spirit
> of bug#5616:
>
>
>
>
> or at least prioritise the current terminal's frames. WDYT?
I think all your proposals are good and make sense. Which one would
you like most?
martin