[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#3
From: |
Eli Zaretskii |
Subject: |
bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106) |
Date: |
Thu, 18 Jan 2018 16:04:05 +0200 |
> From: Philipp Stephani <p.stephani2@gmail.com>
> Cc: Philipp Stephani <phst@google.com>
> Date: Wed, 17 Jan 2018 23:28:46 +0100
>
> * src/systhread.c (sys_thread_equal): New function.
> * src/emacs-module.c (in_current_thread): Use it.
I'd prefer that the only file that calls systhread.c functions is
thread.c; systhread.c is supposed to be low-level code concealed from
application levels. So this would call for another level of
indirection: add a new function to thread.c, and call that from
emacs-module.c.
Otherwise, LGTM for master; thanks.
- bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test', (continued)
- bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test', Eli Zaretskii, 2018/01/17
- bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test', Glenn Morris, 2018/01/17
- bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test', Philipp Stephani, 2018/01/17
- bug#30106: Loading file /sources/emacs/lisp/emacs-lisp/ert.elc failed to provide feature `mod-test', Philipp Stephani, 2018/01/17
- bug#30106: [PATCH 1/2] Use recommended long options syntax in man page, Philipp Stephani, 2018/01/17
- bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106), Philipp Stephani, 2018/01/17
- bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106),
Eli Zaretskii <=
- bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106), Philipp Stephani, 2018/01/18
- bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106), Eli Zaretskii, 2018/01/18
- bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106), Glenn Morris, 2018/01/18
- bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106), Eli Zaretskii, 2018/01/18
- bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106), Glenn Morris, 2018/01/18
- bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106), Eli Zaretskii, 2018/01/19
- bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106), Glenn Morris, 2018/01/20
- bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106), Eli Zaretskii, 2018/01/20
- bug#30106: [PATCH 2/2] Fix module support if threads are disabled (Bug#30106), Philipp Stephani, 2018/01/18
- bug#30106: [PATCH 1/2] Use recommended long options syntax in man page, Philipp Stephani, 2018/01/17