[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#29465: 25.3; Confusing message for dired-do-shell-command substituti
From: |
Tino Calancha |
Subject: |
bug#29465: 25.3; Confusing message for dired-do-shell-command substitution |
Date: |
Sat, 02 Dec 2017 16:32:16 +0900 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Allen Li <vianchielfaura@gmail.com> writes:
Thank you for the new patches Allen!
I don't have strong opinions on this thread; probably because
I am already in Christmass mode or something... Anyway, I think
you guys are discussing pretty well the thing!
I have just two comments in the second patch:
> +;;;###autoload
> +(defcustom dired-confirm-shell-command t
> + "Whether to prompt for confirmation for Dired shell commands.
> +If t, prompt"
> + :type '(choice (const :tag "No restrictions" nil)
> + (const :tag "When point is on a file name initially, search
> file names" dwim)
> + (const :tag "Always search in file names" t))
> + :group 'dired
> + :version "26.0")
^^^^
* Version must be 26.1
* The :type looks unrelated with the option.
Maybe better something like this:
:type '(choice (const :tag "Ask confirmation" t)
(const :tag "Never ask confirmation" nil))
> +
> - (string-match regexp res))))
> + (when
> + dired-confirm-shell-command
> + (let ((res cmd)
You might put the option in the same line as `when', i.e.:
(when dired-confirm-shell-command