[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#22689: [PATCH] Add logcount
From: |
Mark Oteiza |
Subject: |
bug#22689: [PATCH] Add logcount |
Date: |
Sat, 30 Sep 2017 12:59:04 -0400 |
User-agent: |
NeoMutt/20170912-48-0df7d3-dirty |
On 30/09/17 at 06:50pm, Benjamin Riefenstahl wrote:
> Hi Mark,
>
> Just a drive-by note:
>
> Mark Oteiza writes:
> > + {
> > + unsigned int count;
> > + for (count = 0; v; count++)
> > + {
> > + v &= v - 1;
> > + }
> > + XSETINT (res, v);
> > + }
>
> Isn't this a fancy way of just saying "XSETINT (res, 0)"? The variable
> "count" is incremented but never used, so without it the loop
> degenerates to
>
> while (v)
> {
> v &= v - 1;
> }
>
> I other words, this just loops until "v == 0".
>
> Maybe that assignment should be "XSETINT (res, count)"? That would
> actually use the variable "count".
I think you're right, thank you.
- bug#22689: [PATCH] Add logcount, (continued)
- bug#22689: [PATCH] Add logcount, Mark Oteiza, 2017/09/30
- bug#22689: [PATCH] Add logcount, Eli Zaretskii, 2017/09/30
- bug#22689: [PATCH] Add logcount, Mark Oteiza, 2017/09/30
- bug#22689: [PATCH] Add logcount, Eli Zaretskii, 2017/09/30
- bug#22689: [PATCH] Add logcount, Mark Oteiza, 2017/09/30
- bug#22689: [PATCH] Add logcount, Eli Zaretskii, 2017/09/30
- bug#22689: [PATCH] Add logcount, Mark Oteiza, 2017/09/30
- bug#22689: [PATCH] Add logcount, Eli Zaretskii, 2017/09/30
- bug#22689: [PATCH] Add logcount, Mark Oteiza, 2017/09/30
- bug#22689: [PATCH] Add logcount, Benjamin Riefenstahl, 2017/09/30
- bug#22689: [PATCH] Add logcount,
Mark Oteiza <=
bug#22689: [PATCH] Add logcount, Paul Eggert, 2017/09/30