[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#27597: [PATCH] fix warnings in src/xdisp.c
From: |
Eli Zaretskii |
Subject: |
bug#27597: [PATCH] fix warnings in src/xdisp.c |
Date: |
Sat, 08 Jul 2017 11:19:32 +0300 |
> From: Alexander Kuleshov <kuleshovmail@gmail.com>
> Date: Thu, 6 Jul 2017 17:47:03 +0600
>
> here is simple fix for following warnings:
>
> xdisp.c: In function ‘Fdump_glyph_matrix’:
> xdisp.c:19320:20: error: format ‘%lld’ expects argument of type ‘long
> long int’, but argument 3 has type ‘ptrdiff_t {aka long int}’
> [-Werror=format=]
> fprintf (stderr, "PT = %"pI"d, BEGV = %"pI"d. ZV = %"pI"d\n",
>
> from src/xdisp.c
Thanks, pushed to master.
In the future, please provide a commit log message that is according
to our coding standards:
. mention the names of functions in which you make changes
. start sentences with a capital letter
. mention the bug number
Here's the log message I used in this case:
* src/xdisp.c (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
Use pD directives for ptrdiff_t values instead of pI, to avoid
compilation warnings on 64-bit hosts. (Bug#27597)