[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#27405: 25.2; Make eshell-next-prompt more reliable
From: |
Pierre Neidhardt |
Subject: |
bug#27405: 25.2; Make eshell-next-prompt more reliable |
Date: |
Sat, 17 Jun 2017 10:08:13 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
Current definition of `eshell-next-prompt' merely skips a
paragraph. This won't produce the right result as soon the output
contains a paragraph separator (typically an empty line).
I have been using the following redefinition for a while and it works much
better for me:
(defun eshell-next-prompt (n)
"Move to end of Nth next prompt in the buffer.
See `eshell-prompt-regexp'."
(interactive "p")
(re-search-forward eshell-prompt-regexp nil t n)
(when eshell-highlight-prompt
(while (not (get-text-property (line-beginning-position)
'read-only) )
(re-search-forward eshell-prompt-regexp nil t n)))
(eshell-skip-prompt))
(defun eshell-previous-prompt (n)
"Move to end of Nth previous prompt in the buffer.
See `eshell-prompt-regexp'."
(interactive "p")
(backward-char)
(eshell-next-prompt (- n))))
Quite naturally, I search for the `eshell-prompt-regexp'. If that prompt
is too simple (say "^\$ "), some output could easily match the regexp
and the function would move the point there instead of its right
location. To work around that case, I check if the text is read-only,
which is a property of the prompt (if `eshell-highlight-prompt' is `t')
but not of the output.
What do you think? Would you accept a patch?
In GNU Emacs 25.2.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.22.10)
of 2017-04-22 built on juergen
Windowing system distributor 'The X.Org Foundation', version 11.0.11903000
System Description: Arch Linux
- bug#27405: 25.2; Make eshell-next-prompt more reliable,
Pierre Neidhardt <=