bug-gnu-emacs
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#24725: 25.1.50; vc-region-history may exceed max line number of file

From: Dmitry Gutov
Subject: bug#24725: 25.1.50; vc-region-history may exceed max line number of file in repository
Date: Thu, 20 Oct 2016 13:21:00 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 
On 20.10.2016 11:09, Tino Calancha wrote:


Shouldn't that be fixed in the caller, and lto always be decremented if
the regions ends at bol?

I think you are right.  Otherwise we are including a line out of the
region, i.e., in interactive calls we also search in the history for
a line out of the highlighted region.
How about following new patch?


LGTM, please install.

Although I was thinking of simplifying it to just:

(line-number-at-pos (1- to))

That can only bite us if TO is at bob, which would be very unusual.
reply via email to
[Prev in Thread] Current Thread [Next in Thread]