bug#24368: 25.1; Assertion failure in attach_marker

[martin rudalics]

>>   > I agree that erroring out of goto-char in this case is sub-optimal at
>>   > best.
>>
>> Could we drop that restriction with your changes?  I'd rather have this
>> handled safely at one place only.
>
> The patch fixes that as well, didn't you notice?  Or am I missing
> something?

It's perfect.

>>   > P.S. After fixing the crashes and correcting window--state-get-1,
>>   > running your original test case causes "C-x 1" stop working: it has no
>>   > effect.  Looks like this is because Emacs thinks the window is the
>>   > major non-side window, although actually I have *scratch* and *Help*,
>>   > so the command ought to work.  Is this related or unrelated to the
>>   > issue at hand?
>>
>> I'm not sure what you mean with "stop working".  The idea is that C-x 1
>> when invoked in *scratch* should leave the *Help* window alone.
>
> Really?  Isn't that confusing to do that silently?  It confused me,
> for one.

Actually, it's the only standard CEDET/ECB specific feature I
implemented by default.  With ECB, windows outside the editing area are
persistent, you can't even delete them via ‘delete-window’ IIRC.  This,
or having ‘other-window’ skip side windows, must be specified explicitly
with the side windows approach.

I'll add an option to make this easily customizable.

martin