bug#22434: 25.0.50; recentf pastes X clipboard upon opening

[Stefan Monnier]

Ping?


        Stefan


>>>>> "Stefan" == Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>> Does the attached fit the bill?  It works for me.  I hope I got the
>> formalities right.

>> IMO on master we really should either fix
>> mouse--down-1-maybe-follows-link like in #23288 or re-think this
>> strategy of generating an event for some random unknown consumer.

> Thinking about it some more, I think we have a deeper problem: it's not
> just for these recentf buttons that we shouldn't remap mouse-1 to
> mouse-2.  It's for all widget buttons that have a mouse-1 binding to
> widget-button-click (of course, I consider the `down-mouse-1' binding to
> widget-button-click to be a bug as well (it should be bound to `mouse-1'
> instead) but I'd rather not touch this for now).

> The mouse-1 to mouse-2 remapping is to magically let mouse-1 work for
> "follow-link" depending on the value of mouse-1-click-follows-link, but
> here mouse-1 will always follow the link anyway, so remapping
> is undesirable.

> AFAIK we inherit the follow-link property from wid-edit's

>     (define-widget 'link 'item
>       "An embedded link."
>       :button-prefix 'widget-link-prefix
>       :button-suffix 'widget-link-suffix
>       :follow-link 'mouse-face
>       :help-echo "Follow the link."
>       :format "%[%t%]")

> but I don't understand why we need this follow-link property there.

> I understand that changing this part of wid-edit in emacs-25 is too
> risky at this stage, so we'll probably want some stop-gap fix in the
> mean time, but I'd prefer for the stop-gap not to add too much ugly hack.

> How 'bout the patch below, which seems to do the trick for me?


>         Stefan


> diff --git a/lisp/recentf.el b/lisp/recentf.el
> index df7f3e2..cab4a27 100644
> --- a/lisp/recentf.el
> +++ b/lisp/recentf.el
> @@ -1064,7 +1064,7 @@ recentf-dialog-mode-map
>      (define-key km "q" 'recentf-cancel-dialog)
>      (define-key km "n" 'next-line)
>      (define-key km "p" 'previous-line)
> -    (define-key km [follow-link] "\C-m")
> +    ;; (define-key km [follow-link] "\C-m")
>      km)
>    "Keymap used in recentf dialogs.")
 
> @@ -1186,7 +1186,10 @@ recentf-open-files-item
>             :button-face default
>             :format "%[%t\n%]"
>             :help-echo ,(concat "Open " (cdr menu-element))
> -           :action recentf-open-files-action
> +           :action ,#'recentf-open-files-action
> +           ;; Override the (problematic) follow-link property of the
> +           ;; `link' widget (bug#22434).
> +           :follow-link nil
>             ,(cdr menu-element))))
 
>  (defun recentf-open-files-items (files)