bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#22893: 25.1.50; dired-get-marked-files get all marked


From: Tino Calancha
Subject: bug#22893: 25.1.50; dired-get-marked-files get all marked
Date: Thu, 10 Mar 2016 13:19:10 +0900 (JST)
User-agent: Alpine 2.20 (LRH 67 2015-01-07)


Since you are changing the function signatures anyway,
you could make them consistent between `dired-map-over-marks'
and `dired-get-marked-files' by adding an explicit arg `marker-char',
i.e. both `dired-get-marked-files' and `dired-map-over-marks'
could end with "distinguish-one-marked marker-char all-marks",
thus explicitly passing `marker-char' arg down the call chain.
Then you'll need `(or marker-char dired-marker-char)' in
`dired-marker-regexp' for backward-compatibility.  And then also
no need to let-bind `dired-marker-char' in `dired-get-marked-files'
(it's better to avoid dynamically binding global variables where possible).

It sounds good. Thank you. Implemented in the new patch.

Attachment: 0001-Avoid-dynamic-global-var-binding.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]