bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#20241: 25.0.50; `setq' with only one argument


From: Alan Mackenzie
Subject: bug#20241: 25.0.50; `setq' with only one argument
Date: Wed, 25 Nov 2015 11:07:55 +0000
User-agent: Mutt/1.5.23 (2014-03-12)

Hello, Artur.

On Wed, Nov 25, 2015 at 10:36:25AM +0000, Artur Malabarba wrote:
> > We won't see any problem in our own sources, because all the occurrences
> > here have been expunged.  Any problems will be with external libraries
> > (or possibly in *ELPA) which people expect just to download, compile and
> > run.  I think that was what Artur is worried about.

> Since we're going with this, I quickly grepped 4 occurrences on
> elpa/packages (didn't try the external branches). We should probably
> fix those too:

> ./hydra/hydra-test.el:1312:              (setq current-prefix-arg)
> ./tiny/tiny.el:364:                             (setq expect-fun)
> ./gnorb/gnorb-registry.el:294:    (setq id )
> ./context-coloring/benchmark/fixtures/subr.el:1448:     ,@(mapcar
> (lambda (binder) `(setq ,@binder)) binders)

Hmm.  That's worrying.  Isn't the code in ELPA newer code than in the
core?

If you found four occurrences merely by grepping, there could well be
quite a few more.  In the last one, for example, can we be sure that nil
is intended, not that the real argument has just been missed out?

Is there a way of building the entire repository in batch mode?  I've
not had anything to do with ELPA, as yet.  Where do I find the address
of its repository?

Maybe having the byte compiler error out in this situation isn't such a
brilliant idea after all.

-- 
Alan Mackenzie (Nuremberg, Germany).





reply via email to

[Prev in Thread] Current Thread [Next in Thread]