[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#21648: 25.0.50; [PATCH] Add ability to specify radix for the yanked
From: |
Jay Belanger |
Subject: |
bug#21648: 25.0.50; [PATCH] Add ability to specify radix for the yanked number in calc-yank |
Date: |
Thu, 08 Oct 2015 20:04:06 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
Hi!
> Done! I have implemented C-u C-y functionality which will prompt user to
> enter radix between 2 and 36.
>
>> And perhaps some sort of message
>> if the entered radix isn't a number from 2 to 36 (the allowed radixes).
>
> Is that check needed in calc-yank? If I enter an invalid radix like
> 37, I get the generic error "Bad format in yanked data".
But the data might be fine; the problem is with the radix.
>> Also, you probably want to make sure that calc-yank behaves
>> appropriately when a number isn't being yanked.
>
> Can you please provide feedback on how to incorporate that based on the below
> updated code?
To determine whether or not a string represents a number, you could have
Calc parse it, I suppose. But that would be wasteful.
It might be better to add a function, maybe called
`math-numberstring-p', which returns t is the argument is a string
which represents a Calc number. Then along with
(or ((null radix)
(string-match-p "\\`[0-9]+#" thing-raw)
...
you could add
(not (math-numberstring-p thing-raw))
Oh, also, calc-yank can yank more than one line. Currently, if
111
1111
is killed and yanked with C-8 C-y,
the result is
2: 73
1: 1111
and you'd probably want
2: 73
1: 585
Also, the message
(message
(concat "No radix is "
"prepended for prefix "
"value of %0d. Valid "
"numeric prefixes are "
"0, 2, 6, 8.")
radix)
is a bit long.
> I can submit a PATCH once the new definition is confirmed.
I can commit this for you without a patch.
Jay
- bug#21648: 25.0.50; [PATCH] Add ability to specify radix for the yanked number in calc-yank, Kaushal Modi, 2015/10/09
- bug#21648: 25.0.50; [PATCH] Add ability to specify radix for the yanked number in calc-yank, Jay Belanger, 2015/10/08
- bug#21648: 25.0.50; [PATCH] Add ability to specify radix for the yanked number in calc-yank, Kaushal Modi, 2015/10/09
- bug#21648: 25.0.50; [PATCH] Add ability to specify radix for the yanked number in calc-yank, Kaushal Modi, 2015/10/08
- bug#21648: 25.0.50; [PATCH] Add ability to specify radix for the yanked number in calc-yank, Jay Belanger, 2015/10/09
- bug#21648: 25.0.50; [PATCH] Add ability to specify radix for the yanked number in calc-yank, Kaushal Modi, 2015/10/08
- bug#21648: 25.0.50; [PATCH] Add ability to specify radix for the yanked number in calc-yank,
Jay Belanger <=
- bug#21648: 25.0.50; [PATCH] Add ability to specify radix for the yanked number in calc-yank, Kaushal Modi, 2015/10/08
- Message not available
- Message not available
- Message not available
- Message not available
- Message not available
- Message not available
- Message not available
- Message not available
- Message not available
- Message not available
- bug#21648: 25.0.50; [PATCH] Add ability to specify radix for the yanked number in calc-yank, Kaushal Modi, 2015/10/12
bug#21648: 25.0.50; [PATCH] Add ability to specify radix for the yanked number in calc-yank, Eli Zaretskii, 2015/10/09