[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir
From: |
Michael Albinus |
Subject: |
bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted |
Date: |
Mon, 14 Sep 2015 22:23:36 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
> No, I think it's a problem with our mental model of what happens. The
> file notifications use the Emacs event loop, and Emacs won't check for
> events until it's idle. So calling file-notify-valid-p as part of the
> test ends up doing that _before_ the directory deletion notification
> is read by Emacs and invalidates the watch. I actually see the
> message saying the watch is valid before the notification comes in and
> its message is inserted into *Messages*.
>
> Try something similar with inotify and see if you see the same basic
> issue. If you do, I trust you will think of a way to modify the tests
> so that validation does do its thing.
I've adapted `file-notify-test04-file-validity' and
`file-notify-test05-dir-validity', and they pass the tests now for the
inotify case. Hopefully, it is the same for w32notify.
Implementation for gfilenotify and Tramp will follow.
While being there, I have made also `file-notify-rm-watch' more robust
by ignoring all `file-notify-error's. This was the initial trigger for
bug#21432.
Best regards, Michael.
- bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted, (continued)
- bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted, Michael Albinus, 2015/09/08
- bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted, Michael Albinus, 2015/09/12
- bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted, Eli Zaretskii, 2015/09/12
- bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted, Michael Albinus, 2015/09/12
- bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted, Michael Albinus, 2015/09/13
- bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted, Tassilo Horn, 2015/09/14
- bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted, Eli Zaretskii, 2015/09/14
- bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted, Tassilo Horn, 2015/09/14
- bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted, Tassilo Horn, 2015/09/14
- bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted, Eli Zaretskii, 2015/09/14
- bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted,
Michael Albinus <=
- bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted, Eli Zaretskii, 2015/09/15
- bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted, Michael Albinus, 2015/09/15
- bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted, Eli Zaretskii, 2015/09/15
- bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted, Michael Albinus, 2015/09/15
- bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted, Eli Zaretskii, 2015/09/15
- bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted, Michael Albinus, 2015/09/15
- bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted, Michael Albinus, 2015/09/16
- bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted, Eli Zaretskii, 2015/09/16
- bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted, Michael Albinus, 2015/09/16
- bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted, Eli Zaretskii, 2015/09/16