bug#21340: 24.5; trash-directory uses FreeDesktop location on OSX

[Harvey Chapman]

> On Aug 24, 2015, at 1:32 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> From: Harvey Chapman <hchapman@3gfp.com>
>> Date: Mon, 24 Aug 2015 12:55:19 -0400
>> 
>> I set "(setq delete-by-moving-to-trash t)", and emacs moved
>> deleted files to ~/.local/share/Trash, the FreeDesktop location.
> 
> As expected.
> 
>> The files should have been moved to ~/.Trash, the standard OSX
>> location. I was deleting files in my home directory using dired.
>> 
>> Work around: (setq trash-directory "~/.Trash")
> 
> You need to customize that variable to point to the directory where
> you want your trash.  The doc string says:
> 
>    Directory for `move-file-to-trash' to move files and directories to.
>  This directory is only used when the function `system-move-file-to-trash'
>  is not defined.
>  Relative paths are interpreted relative to `default-directory'.
>  If the value is nil, Emacs uses a freedesktop.org-style trashcan.
>  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> The default is nil, so what you see is Emacs functioning as designed.

I guess I considered it a bug, because `system-move-file-to-trash` is
used by Emacs for Windows to put files in the correct location. If Emacs
can cater to Windows, surely it can cater to another very largely used
OS? Emacs putting files in ~/.local on OSX just makes it appear that it
doesn’t know what it is doing.

Thank you all the same.