bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#19111: 25.0.50; 32 bits temacs.exe is linked with wrong image-base w


From: Óscar Fuentes
Subject: bug#19111: 25.0.50; 32 bits temacs.exe is linked with wrong image-base when built on 64 bit Windows host
Date: Fri, 21 Nov 2014 15:15:32 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

Eli Zaretskii <eliz@gnu.org> writes:

>> +      t=${t#Target: }
>
> Is this portable to Unix shells?  If not, perhaps use the 'eval' trick
> here.

This code is never meant to be executed on other than MSYS(2)/Cygwin.
Does the shell complain if an error is present inside an `if' that it
doesn't enter? In other words, does the shell perform syntactic checks
on code that it doesn't execute?

>> +      if test "x$t" = "x"; then
>> +      AC_MSG_ERROR([Impossible to determine $cc compiler target.
>> +Please explicitly provide --target])
>
> I would replace this with a warning and go with $canonical as it was
> determined before.

`configure' outputs hundreds of messages on quick succession. Warnings
are useless for the average users (warnings just go unnoticed.) Apart
from that, if at the user's end the script fails to get the Target from
the compiler, we would like to know about that new compiler on
emacs-devel/bugs (gcc 4.x and clang should work; dunno about old gcc
versions but I expect that 3.x is fine too.)

> Otherwise, I think this is good to go in, but please wait for a couple
> of days to let others comment if they want.

Ok.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]