bug#18902: Emacs 24.4 doesn't respect X resources

[Rogério Brito]

Dear Stefan,

On Oct 31 2014, Stefan Monnier wrote:
> > Debian has just upgraded Emacs 24.3 to 24.4 and one thing stopped
> > working: It seems that Emacs 24.4 does not respect all the X resources
> > that I used to specify (for many, many, many years) in my .Xresources
> > file.
> > 
> > Going back to 24.3 makes the configuration work again. Going forward to
> > 24.4 makes it stop. Tested multiple times just in case I was going nuts.
> > 
> > In particular, I set the geometry, foreground and background colors with
> > the following:
> > 
> > - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
> > Emacs*cursorColor:          red
> > Emacs*geometry:                     100x45
> > Emacs*Background:           #002540
> > Emacs*Foreground:           azure3
> 
> Can you reproduce the problem with "emacs -q" (with lower-case "q",
> since "-Q" ignores Xresources)?

Yes, I can reproduce this with -q.

> Is the above from your .Xresources or from the output of "xrdb -query"
> (I ask since Emacs himself doesn't read the .Xresources file)?

This is from my .Xresources file, but they are also spit with xrdb -query.
*BUT*, in the mean time, I did the following:

* I am using the MATE desktop environment (essentially, GNOME 2) and I get
  the X resources ignored with Emacs 24.4, but everything worked just fine
  with Emacs 24.3.

* I tried installing and seeing the behavior with LXDE, GNOME 3 Classic
  (regular GNOME 3 just crashed), and  XFCE.  Emacs 24.4 loaded the
  resources just fine with these.
  
* Then, I became more adventurous and spent a lot of time git bisecting the
  emacs tree and after a lot of electrical energy/heat, I discovered that
  the first bad commit is, indeed, related to faces and X resources.

  The commit is 15e14b165dcbc6566a0459b0d5e66f89080f569e and right at the
  bottom of the comment is

    * faces.el (face-spec-set): Use face-spec-recalc in all cases.
    (face-spec-reset-face): Don't assign extra properties in temacs.
    (face-spec-recalc): Apply X resources too.

  The commit (in more than one place) is:

    
https://github.com/emacs-mirror/emacs/commit/15e14b165dcbc6566a0459b0d5e66f89080f569e
    
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=15e14b165dcbc6566a0459b0d5e66f89080f569e

I am attaching the git bisect log. Given the commit above, is this a bug
with Emacs or should I report things elsewhere?


Thank you very much,

-- 
Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFCAAAA
http://cynic.cc/blog/ : github.com/rbrito : profiles.google.com/rbrito
DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br

git-bisect-log.log
Description: Text document