bug#16520: 24.3.50; cl-defstruct with :predicate option

[Helmut Eller]

On Wed, Jan 29 2014, Stefan Monnier wrote:

>> The fix doesn't work for this example:
>
>>  (require 'cl-lib)
>>  (cl-defstruct (foo (:predicate foo?)))
>>  (defun bar (x) (cl-check-type x foo))
>
> Indeed.  But it should work for:
>
>    (require 'cl-lib)
>    (cl-defstruct (foo (:predicate foo?)))
>    (defun bar (x) (cl-check-type x foo?))

Which is arguably a bug.  If the goal is to imitate Common Lisp
semantics then the type name is foo not foo?.  If I wanted to call a
predicate I would have written (check-type x (satisfies foo?)).

>> neither for
>>   (cl-defstruct (foo (:predicate nil)))
>
> Not sure if it should work in that case,

It does work in Common Lisp.

Helmut