[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#16285: 24.3.50; [PATCH] shr: handle <a> tag with blank error.
From: |
Kenjiro NAKAYAMA |
Subject: |
bug#16285: 24.3.50; [PATCH] shr: handle <a> tag with blank error. |
Date: |
Sun, 05 Jan 2014 20:47:12 +0900 |
User-agent: |
mu4e 0.9.9.6pre2; emacs 24.3.50.3 |
> I've now fixed this in a different manner. Your patch would have bugged
> out if the empty anchor was the first element in the buffer, so I just
> made it insert a "*" if we have an empty anchor.
Thanks!
> The anchoring mechanism should perhaps be implemented in a different
> way -- markers instead of text properties, for instance? That way
The markers is good idea. Inserting "*" is not bad,
but if it is possible, markers is good.
Kenjiro
larsi@gnus.org writes:
> Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com> writes:
>
>> * net/eww.el (shr-descend): Handle <a> tag with blank error.
>
> I've now fixed this in a different manner. Your patch would have bugged
> out if the empty anchor was the first element in the buffer, so I just
> made it insert a "*" if we have an empty anchor.
>
> The anchoring mechanism should perhaps be implemented in a different
> way -- markers instead of text properties, for instance? That way
> zero-length anchors would be no problem. Rewriting it in that way
> should probably wait until after the feature freeze, though.