|
From: | Dmitry Gutov |
Subject: | bug#14989: 24.3.50; log-view-diff and log-view-diff-changeset default to different `to' revisions for git merge commits |
Date: | Wed, 31 Jul 2013 15:26:45 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 |
Done! On 31.07.2013 04:38, Stefan Monnier wrote:
This fix is simple enough. Apply?Looks good, thanks.The functions could also use some further cleanup: 1) Swap the `to' and `fr' local variables.I think that would make sense, yes.2) Extract the function bodies to one function with a third argument (called `whole-changeset', maybe), and make them call it.If that can be done without too much extra code, that sounds good.
[Prev in Thread] | Current Thread | [Next in Thread] |