[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#14637: recent viper-mode regression
From: |
Juri Linkov |
Subject: |
bug#14637: recent viper-mode regression |
Date: |
Wed, 19 Jun 2013 23:53:07 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) |
>> Grepping for `shell-command-on-region' revealed the exhaustive list
>> of the callers that are fixed now with this patch to set both args
>> OUTPUT-BUFFER and REPLACE to the same value in unison:
>
> Do all the callers need to be fixed? Most of them? A minority only?
> If it's not just a minority, then maybe the better fix is to revert
> revno:112695 (or at least change it) so that existing code doesn't need
> to be changed.
I fixed all the callers that missed the required REPLACE arg:
5 were in vi mode, and 1 in mh-e. They are just a minority
out of total 25 occurrences of `shell-command-on-region'.