[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed
From: |
martin rudalics |
Subject: |
bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed |
Date: |
Fri, 14 Dec 2012 11:26:04 +0100 |
> The doubt raises the fact that evaluating the expression after
> selecting " *Marked Files*" was intentionally coded this way
> in `dired-mark-pop-up':
>
> (with-selected-window window
> (unwind-protect
> (apply function args)
> (when (window-live-p window)
> (quit-restore-window window 'kill))))
>
> I guess the reason was to allow quit-restore-window to kill the
> " *Marked Files*" buffer after the minibuffer (that reads a command)
> is displayed and exited in `(apply function args)'.
I suppose we can safely do
#'(lambda (window _value)
(unwind-protect
(apply function args)
(with-selected-window window
(when (window-live-p window)
(quit-restore-window window 'kill)))))
instead if people think it's better. But FUNCTION "should not
manipulate files, just read input \(an argument or confirmation)." so I
don't see why this matters.
martin
- bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed, (continued)
- bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed, Juri Linkov, 2012/12/12
- bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed, Leo, 2012/12/12
- bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed, Juri Linkov, 2012/12/12
- bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed, Leo, 2012/12/12
- bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed, Juri Linkov, 2012/12/13
- bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed, Leo, 2012/12/13
- bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed, martin rudalics, 2012/12/14
- bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed, Leo, 2012/12/14
- bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed, martin rudalics, 2012/12/14
- bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed,
martin rudalics <=
- bug#13152: 24.2.90; [REGRESSION] dired-get-marked-files changed, Juri Linkov, 2012/12/15