[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#12881: Assume at least POSIX.1-1988 for fcntl.h
From: |
Paul Eggert |
Subject: |
bug#12881: Assume at least POSIX.1-1988 for fcntl.h |
Date: |
Sat, 17 Nov 2012 20:41:24 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 |
On 11/17/2012 07:46 PM, Eli Zaretskii wrote:
> O_RDWR doesn't need to be defined
> (it is already defined by a Windows system header)
OK, sorry, I misunderstood your earlier recommendation (to move
O_NOCTTY) to also refer to O_RDWR. If you like, I can easily
remove the unnecessary definition of O_RDWR in nt/inc/unistd.h.
> defining O_NOCTTY in a header included by many sources is wrong, because it
> triggers compilation of other non-Windows friendly code elsewhere.
No, there's no "#ifdef O_NOCTTY" or "#if ... defined O_NOCTTY ..."
anywhere in Emacs that would be affected by this definition.
The non-Microsoft code already falls back on "#define O_NOCTTY 0"
for platforms that lack O_NOCTTY, and the Microsoft code can
safely do the same.
> Looks like I invested all that effort in vain
I don't see why here, either. Neither of these appear to be problems
that would break a build or cause Emacs to misbehave. And even if they
were, any fixes would be trivial.
- bug#12881: Assume at least POSIX.1-1988 for fcntl.h, (continued)
- bug#12881: Assume at least POSIX.1-1988 for fcntl.h, Stefan Monnier, 2012/11/16
- bug#12881: Assume at least POSIX.1-1988 for fcntl.h, Juanma Barranquero, 2012/11/16
- bug#12881: Assume at least POSIX.1-1988 for fcntl.h, Juanma Barranquero, 2012/11/16
- bug#12881: Assume at least POSIX.1-1988 for fcntl.h, Eli Zaretskii, 2012/11/16
- bug#12881: Assume at least POSIX.1-1988 for fcntl.h, Drew Adams, 2012/11/16
- bug#12881: Assume at least POSIX.1-1988 for fcntl.h, Paul Eggert, 2012/11/17
- bug#12881: Assume at least POSIX.1-1988 for fcntl.h, Eli Zaretskii, 2012/11/17
- bug#12881: Assume at least POSIX.1-1988 for fcntl.h,
Paul Eggert <=
- bug#12881: Assume at least POSIX.1-1988 for fcntl.h, Eli Zaretskii, 2012/11/18
bug#12881: Assume at least POSIX.1-1988 for fcntl.h, Paul Eggert, 2012/11/15