[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#10040: 24.0.91; isearch.el - binding of user options
From: |
Juri Linkov |
Subject: |
bug#10040: 24.0.91; isearch.el - binding of user options |
Date: |
Tue, 15 Nov 2011 21:17:06 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (x86_64-pc-linux-gnu) |
> 3. And yet you do it, so perhaps you would like to consider code where
> you do it as bugs. Assuming that, let me help by pointing out that you
> do it in each of the Isearch help commands: isearch-help-for-help,
> isearch-describe-bindings, and isearch-describe-key. The user options
> you let-bind are `same-window-names' and `same-window-regexps'.
As discussed recently in bug#3419, they should be replaced with
`inhibit-same-window':
=== modified file 'lisp/isearch.el'
--- lisp/isearch.el 2011-11-15 14:33:18 +0000
+++ lisp/isearch.el 2011-11-15 19:14:07 +0000
@@ -378,7 +378,7 @@ (make-help-screen isearch-help-for-help-
(defun isearch-help-for-help ()
"Display Isearch help menu."
(interactive)
- (let (same-window-buffer-names same-window-regexps)
+ (let ((display-buffer-overriding-action '(nil (inhibit-same-window . t))))
(isearch-help-for-help-internal))
(isearch-update))
@@ -386,7 +386,7 @@ (defun isearch-describe-bindings ()
"Show a list of all keys defined in Isearch mode, and their definitions.
This is like `describe-bindings', but displays only Isearch keys."
(interactive)
- (let (same-window-buffer-names same-window-regexps)
+ (let ((display-buffer-overriding-action '(nil (inhibit-same-window . t))))
(with-help-window "*Help*"
(with-current-buffer standard-output
(princ "Isearch Mode Bindings:\n")
@@ -395,14 +395,14 @@ (defun isearch-describe-bindings ()
(defun isearch-describe-key ()
"Display documentation of the function invoked by isearch key."
(interactive)
- (let (same-window-buffer-names same-window-regexps)
+ (let ((display-buffer-overriding-action '(nil (inhibit-same-window . t))))
(call-interactively 'describe-key))
(isearch-update))
(defun isearch-describe-mode ()
"Display documentation of Isearch mode."
(interactive)
- (let (same-window-buffer-names same-window-regexps)
+ (let ((display-buffer-overriding-action '(nil (inhibit-same-window . t))))
(describe-function 'isearch-forward))
(isearch-update))