[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#114: Shell-mode: File completion breaks editing previous commands
From: |
Stefan Monnier |
Subject: |
bug#114: Shell-mode: File completion breaks editing previous commands |
Date: |
Wed, 12 Oct 2011 08:39:40 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) |
>> But that's also the case before my patch, right? So it's not
>> a consequence of my patch.
> OK then, pretend I said:
> I'm also not sure what consequences simply removing this field property
> will have.
> However, I noticed that your patch leaves the help-echo and mouse-face
> properties missing on the completed text, which is a little unaesthetic.
> An alternative solution that avoids this issue would be if callers of
> completion could optionally request that it insert-and-inherit the
> completed text rather than just insert it. I could imagine that other
> callers of completion might need such a feature. But I have no idea if
> this is feasible.
I think there are two issues:
1- handling the `insert' case as well as possible, because a lot of code
uses just `insert' (tho in practice very few cases seem to show up:
yank, completion, any other?).
2- changing (some) users of `insert' such as completion to use
insert-and-inherit.
(2) might be good, indeed, tho I'm not completely sure what are the
consequences.
Stefan