[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#1858: cleanup: POLL_FOR_INPUT
From: |
Lars Magne Ingebrigtsen |
Subject: |
bug#1858: cleanup: POLL_FOR_INPUT |
Date: |
Sun, 10 Jul 2011 16:52:14 +0200 |
User-agent: |
Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) |
Dan Nicolaescu <dann@ics.uci.edu> writes:
> POLL_FOR_INPUT is defined in both process.c and keyboard.c, but not
> exactly the same way:
>
> keyboard.c:
> /* If we support a window system, turn on the code to poll periodically
> to detect C-g. It isn't actually used when doing interrupt input.
> */
> #ifdef HAVE_WINDOW_SYSTEM
> #define POLL_FOR_INPUT
> #endif
>
> process.c:
> /* If we support a window system, turn on the code to poll periodically
> to detect C-g. It isn't actually used when doing interrupt input.
> */
> #if defined(HAVE_WINDOW_SYSTEM) && !defined(USE_ASYNC_EVENTS)
> #define POLL_FOR_INPUT
> #endif
>
> keyboard.h has an #ifdef POLL_FOR_INPUT, but keyboard.h is included
> before POLL_FOR_INPUT is defined...
>
> The above is messy...
keyboard.h no longer has any #ifdef POLL_FOR_INPUT, so now the only
possible confusion is the two different things that turn on
POLL_FOR_INPUT in the two different .c files:
> #ifdef HAVE_WINDOW_SYSTEM
> #if defined(HAVE_WINDOW_SYSTEM) && !defined(USE_ASYNC_EVENTS)
Is this a bug, or are the two .c files supposed to have different
conditions for when to switch POLL_FOR_INPUT on?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
- bug#1858: cleanup: POLL_FOR_INPUT,
Lars Magne Ingebrigtsen <=