[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#8722: dbusbind.c fixes for integer issues, e.g., integer overflow
From: |
Michael Albinus |
Subject: |
bug#8722: dbusbind.c fixes for integer issues, e.g., integer overflow |
Date: |
Tue, 24 May 2011 09:04:49 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
Paul Eggert <eggert@cs.ucla.edu> writes:
> I found some integer overflow issues in dbusbind.c and came up
> with the following patch which I'd like to install. This doesn't
> fix all the integer overflow problems in dbusbind.c, but it makes
> some progress anyway.
On a raw look, it seems to be OK. Minor remark: Why do you need
xd_invalid_serial? You could call instead
XD_SIGNAL2 (build_string ("Invalid dbus serial"), x);
which returns a `dbus-error', and which is more sensible when reading
DBus events.
Best regards, Michael.