[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer
From: |
Leo |
Subject: |
bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer |
Date: |
Mon, 18 Oct 2010 03:16:44 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.2 (Mac OS X 10.6.4) |
On 2010-10-18 02:22 +0800, Óscar Fuentes wrote:
> The purpose of the patch you reverted was addressing that annoyance, so
> it is easy to infer that someone indeed was annoyed by that behavior.
[...]
>
> So why don't you implement that instead of reverting a patch that
> corrects a bug? (After killing a buffer, having a list containing
> non-existent buffers is a bug, right? while seeing how the list after
> the second item is reordered is an annoyance, so you are proposing to
> re-introduce a bug for avoiding an annoyance)
On 2010-10-18 02:48 +0800, Stefan Monnier wrote:
> I don't think we should just revert. If the fix for the old problem
> introduces a new problem, we should try and find a solution that fixes
> both problems at once.
>
> Stefan
Sorry for being too lazy. Please try the following patch.
>From d61fe17fff2926731ea317b21d647a4cf2d136f4 Mon Sep 17 00:00:00 2001
Date: Mon, 18 Oct 2010 01:44:24 +0800
Subject: [PATCH] Rebuild buffer list using buffer objects
in iswitchb-kill-buffer.
Avoid `iswitchb-make-buflist' which changes the order of matches seen
by users.
---
lisp/iswitchb.el | 15 ++++++++++-----
1 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/lisp/iswitchb.el b/lisp/iswitchb.el
index 081897a..4cab5ee 100644
--- a/lisp/iswitchb.el
+++ b/lisp/iswitchb.el
@@ -1033,7 +1033,9 @@ Return the modified list with the last element prepended
to it."
(setq buf (car iswitchb-matches))
;; check to see if buf is non-nil.
(if buf
- (progn
+ (let ((bufobjs (mapcar (lambda (name)
+ (or (get-buffer name) name))
+ iswitchb-buflist)))
(kill-buffer buf)
;; Check if buffer exists. XEmacs gnuserv.el makes alias
@@ -1042,10 +1044,13 @@ Return the modified list with the last element
prepended to it."
(if (get-buffer buf)
;; buffer couldn't be killed.
(setq iswitchb-rescan t)
- ;; Else `kill-buffer' succeeds so re-make the buffer list
- ;; taking into account packages like uniquify may rename
- ;; buffers
- (iswitchb-make-buflist iswitchb-default))))))
+ ;; else buffer was killed
+ (setq iswitchb-buflist
+ (delq nil (mapcar (lambda (b)
+ (if (bufferp b)
+ (buffer-name b)
+ b))
+ bufobjs))))))))
;;; VISIT CHOSEN BUFFER
(defun iswitchb-visit-buffer (buffer)
--
1.7.3
- bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer, Leo, 2010/10/17
- bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer, Óscar Fuentes, 2010/10/17
- bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer,
Leo <=
- bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer, Stefan Monnier, 2010/10/18
- bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer, Leo, 2010/10/19
- bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer, Leo, 2010/10/20
- bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer, Óscar Fuentes, 2010/10/20
- bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer, Leo, 2010/10/21
- bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer, Stefan Monnier, 2010/10/20
- bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer, Leo, 2010/10/23
- bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer, Stefan Monnier, 2010/10/27
bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer, Stefan Monnier, 2010/10/17