bug#6222: Shouldn't f1 in isearch-mode be help?

[Lennart Borgman]

On Thu, May 20, 2010 at 2:20 AM, Juri Linkov <juri@jurta.org> wrote:
>> C-h gives isearch help in isearch, but f1 does not. Should not both do
>> the same for consistency?
>>
>> And should not `help-char' (or [help]) be used instead of C-h in the code?
>>
>> The doc string for isearch does not mention that you now have this
>> good help for isearch during isearch. Shouldn't it do that?
>>
>> BTW: My bad memory can't find a variable that is holding both C-h and
>> f1. Wasn't there such a variable?
>
> There is no such variable.  E.g. in help.el help bindings are repeated
> three times:
>
>    (define-key map (char-to-string help-char) 'help-for-help)
>    (define-key map [help] 'help-for-help)
>    (define-key map [f1] 'help-for-help)
>
> and
>
>    (define-key global-map (char-to-string help-char) 'help-command)
>    (define-key global-map [help] 'help-command)
>    (define-key global-map [f1] 'help-command)


Thanks, I see. But shouldn't isearch do the same then?

What about having a function in help.el for defining a binding for all
three possibilities? Something like

  (defun help-define-help-keys (map command)
    (define-key map (char-to-string help-char) command)
    (define-key map [help] command)
    (define-key map [f1] command))