bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#5149: 23.1; doc string of `minibuffer-with-setup-hook'


From: Drew Adams
Subject: bug#5149: 23.1; doc string of `minibuffer-with-setup-hook'
Date: Mon, 7 Dec 2009 10:24:49 -0800

Doc string:
 
"Add FUN to `minibuffer-setup-hook' while executing BODY.
BODY should use the minibuffer at most once.
Recursive uses of the minibuffer will not be affected."
 
Please state explicitly that FUN is removed from
`minibuffer-setup-hook' when the minibuffer is exited.
 
The use of "while executing BODY" suggests that somewhat, but it is
not clear enough. It says it is _added_ while executing, but it
doesn't say that it is removed.
 
In fact, FUN is not really added to hook `minibuffer-setup-hook'.
Someone or some code looking for FUN on the hook will never find it
there.
 
Instead, a proxy function that invokes FUN is added to the hook. So it
would be more accurate to say that FUN is added, "in effect", or
something like that.
 

In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600)
 of 2009-07-29 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4)'
 







reply via email to

[Prev in Thread] Current Thread [Next in Thread]