bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#1233: rcirc fill-region bugfix


From: Ryan Yeske
Subject: bug#1233: rcirc fill-region bugfix
Date: Mon, 27 Oct 2008 20:06:36 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)

Chong Yidong <cyd@stupidchicken.com> writes:

> Hi Ryan,
>
> Could you review this patch?

It looks good to me.  Thanks for the patch, Jeff.

The way filling is handled in the CVS trunk has been reworked, and it
includes a fix along these lines already.

Ryan



> Jeff Makey <jeff@sdsc.edu> wrote:
>
>> When a message begins with a very long word (typically a URL), rcirc
>> in Emacs 22 inserts a useless newline like this:
>>
>> 08:10 <SaintNick>
>>                   
>> http://lists.gnu.org/archive/html/bug-gnu-emacs/2008-10/index.html
>>                   has this month's archives
>>
>> The patch below excludes the timestamp and nick from the beginning of
>> the filled region, which will cause such a line to be shown in this
>> more compact format:
>>
>> 08:10 <SaintNick> 
>> http://lists.gnu.org/archive/html/bug-gnu-emacs/2008-10/index.html
>>                   has this month's archives
>
>
> --- rcirc.el.orig     2008-02-10 06:03:53 -0800
> +++ rcirc.el  2008-10-08 23:33:57 -0700
> @@ -1251,7 +1251,7 @@
>                                        (rcirc-fill-column
>                                         rcirc-fill-column)
>                                        (t fill-column))))
> -               (fill-region fill-start rcirc-prompt-start-marker 'left t)))))
> +               (fill-region text-start rcirc-prompt-start-marker 'left t)))))
>  
>         ;; set inserted text to be read-only
>         (when rcirc-read-only-flag






reply via email to

[Prev in Thread] Current Thread [Next in Thread]