bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Minor comint.el patch


From: Davis Herring
Subject: Minor comint.el patch
Date: Thu, 25 Sep 2003 07:40:31 -0500 (CDT)

Quoting Richard Stallman's mail of Tue, 23 Sep 2003 19:13:18 -0400:
> David's suggestion seems right to me.
> I will get it installed.  Thanks.

I'm assuming that you're referring either to my comment about
(and pw (send-invisible pw)), or else to Kevin Rodgers' suggestion of
(send-invisible (or pw "")) ...

Unfortunately, neither one of these is particularly useful; neither one of
them prints any sort of message (not even 'Quit') to indicate that the
password is no longer being read invisibly, and the latter actually sends
something (even if it's just a newline) when the user tries to abort the
command -- Bad Thing.

I believe what we want is a slight reorganization of those functions;
unless they get heavy Lisp usage, it shouldn't cause much
incompatibility damage.  The attached patch (versus 21.3.1) causes there
to be no further prompt but rather the proper warning when the user quits.
I also added references to 'clear-this-command-keys' in the docstrings;
would it make sense to make that function interactive?

Davis Herring

-- 
Ship Quantum Express -- the honest company that admits to having no idea
when your shipment will get there or where it will be when it does!

Attachment: comint.diff
Description: New vs. 21.3.1


reply via email to

[Prev in Thread] Current Thread [Next in Thread]