Incorrect interactive autoloads in diary-lib.el

[Alan Shutko]

In GNU Emacs 21.2.1 (i386-debian-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2002-03-22 on raven, modified by Debian
configured using `configure  i386-debian-linux-gnu --prefix=/usr 
--sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib 
--infodir=/usr/share/info --mandir=/usr/share/man --with-pop=yes --with-x=yes 
--with-x-toolkit=athena --without-gif'
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: C
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US
  locale-coding-system: iso-latin-1
  default-enable-multibyte-characters: t

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

The autoloads in diary-lib.el specify that the function is
interactive, although it is not.  Here is a patch to correct them.

2002-07-12  Alan Shutko  <ats@acm.org>

        * diary-lib.el (check-calendar-holidays, calendar-holiday-list) 
        (diary-french-date, diary-mayan-date, diary-iso-date) 
        (diary-julian-date, diary-astro-day-number, diary-chinese-date) 
        (diary-islamic-date, list-islamic-diary-entries) 
        (mark-islamic-diary-entries, mark-islamic-calendar-date-pattern) 
        (diary-hebrew-date, diary-omer, diary-yahrzeit, diary-parasha) 
        (diary-rosh-hodesh, list-hebrew-diary-entries) 
        (mark-hebrew-diary-entries, mark-hebrew-calendar-date-pattern) 
        (diary-coptic-date, diary-persian-date, diary-phases-of-moon) 
        (diary-sunrise-sunset, diary-sabbath-candles): Removed interactive
        flag.

*** /home/ats/tmp/diary-lib.el~ Fri Jul 12 14:37:07 2002
--- /home/ats/tmp/diary-lib.el  Fri Jul 12 14:44:03 2002
***************
*** 88,195 ****
  (autoload 'check-calendar-holidays "holidays"
    "Check the list of holidays for any that occur on DATE.
  The value returned is a list of strings of relevant holiday descriptions.
! The holidays are those in the list `calendar-holidays'."
!   t)
  
  (autoload 'calendar-holiday-list "holidays"
    "Form the list of holidays that occur on dates in the calendar window.
! The holidays are those in the list `calendar-holidays'."
!   t)
  
  (autoload 'diary-french-date "cal-french"
!   "French calendar equivalent of date diary entry."
!   t)
  
  (autoload 'diary-mayan-date "cal-mayan"
!   "Mayan calendar equivalent of date diary entry."
!   t)
  
  (autoload 'diary-iso-date "cal-iso"
!   "ISO calendar equivalent of date diary entry."
!   t)
  
  (autoload 'diary-julian-date "cal-julian"
!   "Julian calendar equivalent of date diary entry."
!   t)
  
  (autoload 'diary-astro-day-number "cal-julian"
!   "Astronomical (Julian) day number diary entry."
!   t)
  
  (autoload 'diary-chinese-date "cal-china"
!   "Chinese calendar equivalent of date diary entry."
!   t)
  
  (autoload 'diary-islamic-date "cal-islam"
!   "Islamic calendar equivalent of date diary entry."
!   t)
  
  (autoload 'list-islamic-diary-entries "cal-islam"
!   "Add any Islamic date entries from the diary file to `diary-entries-list'."
!   t)
  
  (autoload 'mark-islamic-diary-entries "cal-islam"
!   "Mark days in the calendar window that have Islamic date diary entries."
!   t)
  
  (autoload 'mark-islamic-calendar-date-pattern "cal-islam"
!    "Mark dates in calendar window that conform to Islamic date 
MONTH/DAY/YEAR."
!   t)
  
  (autoload 'diary-hebrew-date "cal-hebrew"
!   "Hebrew calendar equivalent of date diary entry."
!   t)
  
  (autoload 'diary-omer "cal-hebrew"
!   "Omer count diary entry."
!   t)
  
  (autoload 'diary-yahrzeit "cal-hebrew"
!   "Yahrzeit diary entry--entry applies if date is yahrzeit or the day before."
!   t)
  
  (autoload 'diary-parasha "cal-hebrew"
!   "Parasha diary entry--entry applies if date is a Saturday."
!   t)
  
  (autoload 'diary-rosh-hodesh "cal-hebrew"
!   "Rosh Hodesh diary entry."
!   t)
  
  (autoload 'list-hebrew-diary-entries "cal-hebrew"
!   "Add any Hebrew date entries from the diary file to `diary-entries-list'."
!   t)
  
  (autoload 'mark-hebrew-diary-entries "cal-hebrew"
!   "Mark days in the calendar window that have Hebrew date diary entries."
!   t)
  
  (autoload 'mark-hebrew-calendar-date-pattern "cal-hebrew"
!    "Mark dates in calendar window that conform to Hebrew date MONTH/DAY/YEAR."
!   t)
  
  (autoload 'diary-coptic-date "cal-coptic"
!   "Coptic calendar equivalent of date diary entry."
!   t)
  
  (autoload 'diary-ethiopic-date "cal-coptic"
!   "Ethiopic calendar equivalent of date diary entry."
!   t)
  
  (autoload 'diary-persian-date "cal-persia"
!   "Persian calendar equivalent of date diary entry."
!   t)
  
! (autoload 'diary-phases-of-moon "lunar" "Moon phases diary entry." t)
  
  (autoload 'diary-sunrise-sunset "solar"
!   "Local time of sunrise and sunset as a diary entry."
!   t)
  
  (autoload 'diary-sabbath-candles "solar"
    "Local time of candle lighting diary entry--applies if date is a Friday.
! No diary entry if there is no sunset on that date."
!   t)
  
  (defvar diary-syntax-table (copy-syntax-table (standard-syntax-table))
    "The syntax table used when parsing dates in the diary file.
--- 88,170 ----
  (autoload 'check-calendar-holidays "holidays"
    "Check the list of holidays for any that occur on DATE.
  The value returned is a list of strings of relevant holiday descriptions.
! The holidays are those in the list `calendar-holidays'.")
  
  (autoload 'calendar-holiday-list "holidays"
    "Form the list of holidays that occur on dates in the calendar window.
! The holidays are those in the list `calendar-holidays'.")
  
  (autoload 'diary-french-date "cal-french"
!   "French calendar equivalent of date diary entry.")
  
  (autoload 'diary-mayan-date "cal-mayan"
!   "Mayan calendar equivalent of date diary entry.")
  
  (autoload 'diary-iso-date "cal-iso"
!   "ISO calendar equivalent of date diary entry.")
  
  (autoload 'diary-julian-date "cal-julian"
!   "Julian calendar equivalent of date diary entry.")
  
  (autoload 'diary-astro-day-number "cal-julian"
!   "Astronomical (Julian) day number diary entry.")
  
  (autoload 'diary-chinese-date "cal-china"
!   "Chinese calendar equivalent of date diary entry.")
  
  (autoload 'diary-islamic-date "cal-islam"
!   "Islamic calendar equivalent of date diary entry.")
  
  (autoload 'list-islamic-diary-entries "cal-islam"
!   "Add any Islamic date entries from the diary file to `diary-entries-list'.")
  
  (autoload 'mark-islamic-diary-entries "cal-islam"
!   "Mark days in the calendar window that have Islamic date diary entries.")
  
  (autoload 'mark-islamic-calendar-date-pattern "cal-islam"
!    "Mark dates in calendar window that conform to Islamic date 
MONTH/DAY/YEAR.")
  
  (autoload 'diary-hebrew-date "cal-hebrew"
!   "Hebrew calendar equivalent of date diary entry.")
  
  (autoload 'diary-omer "cal-hebrew"
!   "Omer count diary entry.")
  
  (autoload 'diary-yahrzeit "cal-hebrew"
!   "Yahrzeit diary entry--entry applies if date is yahrzeit or the day 
before.")
  
  (autoload 'diary-parasha "cal-hebrew"
!   "Parasha diary entry--entry applies if date is a Saturday.")
  
  (autoload 'diary-rosh-hodesh "cal-hebrew"
!   "Rosh Hodesh diary entry.")
  
  (autoload 'list-hebrew-diary-entries "cal-hebrew"
!   "Add any Hebrew date entries from the diary file to `diary-entries-list'.")
  
  (autoload 'mark-hebrew-diary-entries "cal-hebrew"
!   "Mark days in the calendar window that have Hebrew date diary entries.")
  
  (autoload 'mark-hebrew-calendar-date-pattern "cal-hebrew"
!    "Mark dates in calendar window that conform to Hebrew date 
MONTH/DAY/YEAR.")
  
  (autoload 'diary-coptic-date "cal-coptic"
!   "Coptic calendar equivalent of date diary entry.")
  
  (autoload 'diary-ethiopic-date "cal-coptic"
!   "Ethiopic calendar equivalent of date diary entry.")
  
  (autoload 'diary-persian-date "cal-persia"
!   "Persian calendar equivalent of date diary entry.")
  
! (autoload 'diary-phases-of-moon "lunar" "Moon phases diary entry.")
  
  (autoload 'diary-sunrise-sunset "solar"
!   "Local time of sunrise and sunset as a diary entry.")
  
  (autoload 'diary-sabbath-candles "solar"
    "Local time of candle lighting diary entry--applies if date is a Friday.
! No diary entry if there is no sunset on that date.")
  
  (defvar diary-syntax-table (copy-syntax-table (standard-syntax-table))
    "The syntax table used when parsing dates in the diary file.

Recent input:
s e r 9 C-g <help-echo> <down-mouse-1> <mouse-1> <down-mouse-1> 
<mouse-1> C-x C-f c a l <tab> e <tab> <return> M-x 
M-p M-p M-p M-n M-p M-p M-p C-g M-x g r e p <return> 
M-p <return> <f1> <f1> SPC <f1> <right> <right> <right> 
C-e <switch-frame> C-x 4 f e m <tab> l i s <tab> / 
c a l <tab> e <tab> d i a <tab> <return> C-s d i a 
r y - f r e n c h - d a t e <return> M-x e <backspace> 
r e p o r t - e m <tab> <return>

Recent messages:
Building cal-coptic.el Semantic directory index imenu
Parsing error messages...done.
Note: file is write protected
Building calendar.el Semantic directory index imenu
Building cal-mayan.el Semantic directory index imenu
Building cal-coptic.el Semantic directory index imenu
Making completion list...
Mark set
Mark saved where search started
Loading emacsbug...done

-- 
Alan Shutko <ats@acm.org> - In a variety of flavors!
In nuclear war, all men are cremated equal.