Re: browse-url-galeon incorrect

[Simon Josefsson]

"Paul Smith"<pausmith@nortelnetworks.com> writes:

> The browse-url.el:browse-url-galeon function is wrong.  It constructs
> the arguments to Galeon like this:
>
>       (concat "galeon " url) nil
>       browse-url-galeon-program
>       (append
>       browse-url-galeon-arguments
>       (if new-window '("-w" "--noraise"))
>       (list "-x" url))
>
> This is broken, though.  The "-x" argument overrides the setting of the
> new-window flag; "-x" means "Attempt to load URL in existing Galeon
> window", and the last such argument on the command line always takes
> precedence.  I think the "-x" should be removed, as I think it's not
> appropriate to have no way of passing _exactly_ the arguments you want,
> and only those.

The current code has been changed into the following.  Does it work
better for you?

...
         (process (apply 'start-process
                         (concat "galeon " url) nil
                         browse-url-galeon-program
                         (append
                          browse-url-galeon-arguments
                          (if (browse-url-maybe-new-window new-window)
                              (if browse-url-galeon-new-window-is-tab
                                  '("--new-tab")
                                '("--new-window" "--noraise"))
                            '("--existing"))
                          (list url)))))
...