gnats/355: Mail agent output is forwarded by gnatsd

[Andrew . Gray]

>Number:         355
>Category:       gnats
>Synopsis:       Mail agent output is forwarded by gnatsd
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Mar 04 04:22:36 -0500 2002
>Originator:     Andrew Gray
>Release:        3.999.1
>Organization:

>Environment:
Intel, Linux 2.4.2-2
>Description:
If the mail agent used to send notification of edits to a
PR generates output then that output is forwarded to the
gnatsd client. This output is not expected by the client.
(For example, Gnatsweb returns to the user a page headed "Error" with the text 
"Unparseable reply from gnatsd".)
>How-To-Repeat:
Add or edit the following line to the categories file:
test:*Test Category:gnats-admin:userone
Add the following lines to the responsible file:
userone:User number one:<bad email address>
Submit a PR in the test category.
Connect to the gnatsd server using a telnet client and perform any necessary 
authentication.
Issue the following commands:
repl <pr_number> State
212 Ok.
closed
.
213 Ok, now send the field change reason.
Testing.
.
/home/gnats/dead.letter... Saved message in /home/gnats/dead.letter
210 Ok.
>Fix:
Change the gnats/mail-agent.sh source file to redirect
the standard output of the mail agent to /dev/null:

Index: mail-agent.sh
===================================================================
RCS file: /cvsroot/gnats/gnats/gnats/mail-agent.sh,v
retrieving revision 1.1
diff -u -p -r1.1 mail-agent.sh
--- mail-agent.sh       22 Dec 1999 04:44:38 -0000      1.1
+++ mail-agent.sh       4 Mar 2002 09:21:03 -0000
@@ -25,4 +25,4 @@

 MAIL_AGENT="xDEFAULT_MAIL_AGENTx"

-exec $MAIL_AGENT $@
+exec $MAIL_AGENT $@ > /dev/null

>Unformatted: