bug-global
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: GLOBAL 5.9.5 DOS/Win Patch


From: Shigio YAMAGUCHI
Subject: Re: GLOBAL 5.9.5 DOS/Win Patch
Date: Wed, 18 May 2011 15:53:31 +0900

Hello Jason,

> > gtags-cscope: re-implemented using cscope's code
> 
> Gee, you make life hard for me. ;)  The patch is here:

Sorry, but people's lives excluding you became happier. :)

> Due to CMD's limitations, the system calls use double quotes instead
> of single quotes; hope that doesn't cause problems.  I also removed
> CURSES_LIB from the dependencies (the make from UnxUtils didn't like
> it, didn't think to try with mingw32-make; djgpp was fine, though, so
> perhaps you could leave it and I'll have another look next release).

About single quotes, I have modified them like follows:
since there is a possibility that command and variable substitutions
(`pwd`, $PATH) happen.

        [gtags-cscope/find.c]

        #if defined(__DJGPP__) || (defined(_WIN32) && !defined(__CYGWIN__))
        #define QUOTE "\""
        #else
        #define QUOTE "'"
        #endif

        snprintf(comline, sizeof(comline), "%s -d %s%s%s > %s", COMMON, QUOTE, 
pattern, QUOTE, temp1);

Please let me know if there is a problem.

Always thank you.
--
Shigio YAMAGUCHI <address@hidden>
PGP fingerprint: D1CB 0B89 B346 4AB6 5663  C4B6 3CA5 BBB3 57BE DDA3



reply via email to

[Prev in Thread] Current Thread [Next in Thread]