Re: [Global-commit] global/htags style.css.tmpl

[Shigio YAMAGUCHI]

Hi,
> This seems to be a mistake. 
> htags/common.c still contains the following code. 

You are right.

>   752                                 strbuf_sprintf(sb, "<div class='%s'>", 
> align);

What an awful code it is!

I have fixed it in the another way.
Always thank you.

Index: htags/common.c
===================================================================
RCS file: /sources/global/global/htags/common.c,v
retrieving revision 1.72
diff -r1.72 common.c
736,738c736
<  * Generate div begin tag.
<  *
<  *    i)      align   right,left,center
---
>  * Generate 'powered by' begin tag.
741c739
< gen_div_begin(const char *align)
---
> gen_poweredby_begin()
747,757c745,751
<               if (align) {
<                       /*
<                        * In XHTML, alignment is defined in the file 
'style.css'.
<                        */
<                       if (enable_xhtml)
<                               strbuf_sprintf(sb, "<div class='%s'>", align);
<                       else
<                               strbuf_sprintf(sb, "<div align='%s'>", align);
<               } else {
<                       strbuf_puts(sb, "<div>");
<               }
---
>               /*
>                * In XHTML, alignment is defined in the file 'style.css'.
>                */
>               if (enable_xhtml)
>                       strbuf_sprintf(sb, "<div class='poweredby'>");
>               else
>                       strbuf_sprintf(sb, "<div align='right'>");
762c756
<  * Generate div end tag.
---
>  * Generate 'powered by' end tag.
765c759
< gen_div_end(void)
---
> gen_poweredby_end(void)
Index: htags/common.h
===================================================================
RCS file: /sources/global/global/htags/common.h,v
retrieving revision 1.35
diff -r1.35 common.h
133,134c133,134
< const char *gen_div_begin(const char *);
< const char *gen_div_end(void);
---
> const char *gen_poweredby_begin(void);
> const char *gen_poweredby_end(void);
Index: htags/htags.c
===================================================================
RCS file: /sources/global/global/htags/htags.c,v
retrieving revision 1.183
diff -r1.183 htags.c
1005c1005
<       strbuf_puts_nl(sb, gen_div_begin("right"));
---
>       strbuf_puts_nl(sb, gen_poweredby_begin());
1020c1020
<       strbuf_puts_nl(sb, gen_div_end());
---
>       strbuf_puts_nl(sb, gen_poweredby_end());
Index: htags/style.css.tmpl
===================================================================
RCS file: /sources/global/global/htags/style.css.tmpl,v
retrieving revision 1.2
diff -r1.2 style.css.tmpl
14a15
> .poweredby    { text-align: right; }

Shigio
--
Shigio YAMAGUCHI <address@hidden>
PGP fingerprint: D1CB 0B89 B346 4AB6 5663  C4B6 3CA5 BBB3 57BE DDA3