bug-global
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[RFC] Meaningless signal handling.


From: Shigio YAMAGUCHI
Subject: [RFC] Meaningless signal handling.
Date: Wed, 05 Oct 2005 13:26:44 +0900

Hi all,

Currently, in gtags, we catch signals and terminate the command safely.

[gtags/gtags.c]
        /* Signal handler */
        void
        onintr(int signo)
        {
                exitflag = 1;
        }

        ...
        /* Termination in suitable timing. */
        if (exitflag)
                exit(1);
        ...

If you push the interrupt key while executing gtags(1), the exitflag will
be set by onintr() first, and the flag will be checked afterwards to
terminate itself. But it seems to be meaningless, because the tags files
are left halfway though are not destroyed. On the other hand, gtags sometimes
does not end at once even if the interrupt key is pushed.

Thinking about the above, I would like to remove above code.
As a result, gtags ends at once if the interrupt key is pushed.

What do you think?
If there is not opposite, I will modify like above.
--
Shigio YAMAGUCHI <address@hidden> - Tama Communications Corporation
PGP fingerprint: D1CB 0B89 B346 4AB6 5663  C4B6 3CA5 BBB3 57BE DDA3




reply via email to

[Prev in Thread] Current Thread [Next in Thread]