[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-gettext] AC_CONFIG_MACRO_DIR{,S} & ACLOCAL_AMFLAGS
From: |
Daiki Ueno |
Subject: |
Re: [bug-gettext] AC_CONFIG_MACRO_DIR{,S} & ACLOCAL_AMFLAGS |
Date: |
Thu, 28 Feb 2013 10:44:35 +0900 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
address@hidden writes:
>> +# Check in which directory gettext.m4 etc. belong.
>> +macrodirs=`cat "$configure_in" | grep '^AC_CONFIG_MACRO_DIR' | sed
>> -n -e 's/AC_CONFIG_MACRO_DIRS\{,1\}(\([^()]*\))/\1/p' | sed -e
>> 's/^\[\(.*\)\]$/\1/'`
>
> cat file | grep foo could be written simplier using
> grep foo file
I know, but just followed the convention used in the surrounding code
(see 3 lines above in the code). Since generally it is not a good idea
to mix a bug fix and refactoring in a single patch, I think it should be
addressed by a separate patch. I also wonder if grep is even necessary.
Anyway, patches are welcome ;)
Regards,
--
Daiki Ueno