Re: [bug-gawk] Bugs in Gawk

[arnold]

Eli Zaretskii <address@hidden> wrote:

> > Date: Mon, 10 Mar 2014 20:57:46 -0300
> > From: Flávio Medeiros <address@hidden>
> > 
> > 1)
> > FILE: pc/popen.c/v1-popen.c
> > PROBLEM: Memory leak in function scriptify, variable cmd (line 90 -
> > return null) when we set configuration defined(_MSC_VER) ||
> > defined(__MINGW32__).
> > 
> > 
> > 2)
> > FILE: regcomp.c/v1-regcomp.c
> > PROBLEM: uninitialized variable in function parse_bracket_exp,
> > variable table_size, when we define macro _LIBC. (around line 2692)
> > 
> > 3)
> > FILE: regcomp.c/v1-regcomp.c
> > PROBLEM: memory in function parse_bracket_exp, variable mbcset, when
> > we define macro RE_ENABLE_I18N with mbcset == NULL. (around line 2970)
> > 
> > Please let me know if it helps.
>
> Thanks.
>
> What version of Gawk did you see these in?  For example, the 1st issue
> no longer exists in the latest version (there's a call to 'free'), and
> the function scriptify is no longer used in the Windows build anyway.
>
> Line numbers also don't seem to be correct.  Perhaps it would be
> better to show the code itself and explain why you think there might
> be a problem there.

I agree - knowing version and seeing code would help. Issue #2 isn't a
problem since gawk does not define _LIBC. I will probably fix it though.

It's harder to see if #3 is an issue because of all the inline code
for the LIBC case, but I suspect it's also not a real problem.

Thanks for sending in the report.

Arnold