bug-findutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: RFC: [PATCH 0/12] tests: migrate to shell-style test framework from


From: Bernhard Voelker
Subject: Re: RFC: [PATCH 0/12] tests: migrate to shell-style test framework from gnulib
Date: Sun, 20 Jan 2019 20:18:47 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 1/9/19 12:52 AM, Bernhard Voelker wrote:
> Hi *,
> 
> we have a couple of shell-script-based tests, and the number of them
> is increasing ... maybe because I like shell scripts. ;-)
> 
> It has become time to move this to the next level, as mentioned
> in the 1st patch:
> 
>   Borrow the 'tests' framework from GNU coreutils.  This allows better
>   shell-style tests with more control over stdin, stdout, stderr, signals,
>   preparatory steps, cleanup, return code verification, root-only tests,
>   etc.
> 
> These are further advantages and facts:
> * do the shell-based tests in 'tests/', not in *'/testsuite/',
> * run the gnulib-tests later during 'make check', so that one doesn't
>   have to wait so long in development environment to get to our tests,
> * use more syntax-check rules for the tests,
> * have a set of central utility functions available,
> * have 'tests/sample-test' as template for new tests.
> 
> This is the series of patches, consisting of the introduction of the
> test framework itself ...
> 
>   [PATCH 01/12] tests: add shell-style test framework
> 
> ... followed by the migration of the existing shell-style tests:
> 
>  [PATCH 02/12] tests: migrate 'many-dir-entries-vs-OOM' to the new testsuite
>  [PATCH 03/12] tests: migrate 'name-lbracket-literal' to the new testsuite
>  [PATCH 04/12] tests: migrate test 'printf_escapechars' to the new testsuite
>  [PATCH 05/12] tests: migrate 'printf_escape_c' to the new testsuite
>  [PATCH 06/12] tests: migrate 'printf_inode' to the new testsuite
>  [PATCH 07/12] tests: migrate 'execdir-fd-leak' to the new testsuite
>  [PATCH 08/12] tests: migrate 'exec-plus-last-file' to the new testsuite
>  [PATCH 09/12] tests: migrate 'refuse-noop' to the new testsuite
>  [PATCH 10/12] tests: migrate 'debug-missing-arg' to the new testsuite
>  [PATCH 11/12] tests: migrate 'type_list' to the new testsuite
>  [PATCH 12/12] tests: remove last traces of old shell tests
> 
> I tested on Linux (openSUSE:Tumbleweed), FreeBSD, NetBSD, OpenBSD
> and Alpine Linux.  I don't currently have access to more platforms,
> so please feel encouraged to run them on more of them: Solaris, HP-UX,
> IRIX, whatever ... .
> 
> WDYT?

No comment means consent - pushed at:
  https://git.sv.gnu.org/cgit/findutils.git/commit/?id=0b483d326c75

Thanks & have a nice day,
Berny



reply via email to

[Prev in Thread] Current Thread [Next in Thread]