bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: mkman.pl patch


From: Derek R. Price
Subject: Re: mkman.pl patch
Date: Mon, 21 Aug 2006 17:01:27 -0400
User-agent: Thunderbird 1.5.0.5 (Windows/20060719)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Kevin R. Bulgrien wrote:
> It just so happens that after years of wanting it, I cracked the book on
> perl two weeks ago...
> 
> This will fix it.  Basically, the "see node" is only used for @pxref{} and
> @xref{}.  Not beautiful, but it does work for cvs.1.  I did make

Not too bad for having only cracked the Perl book two weeks back.

I committed the attached patch instead, to both stable and feature.  It
uses `eq' instead of a regex to match "ref", since `eq' is faster and
removes an unrelated but unnecessary backslash in the replacement text.
 It also avoids interpreting
"xpxxxpxpxpxpxpxxxxxxxpxpxpxpxpxpxpxpxpxxxxxxref", for example, as a
cross reference.  ;)

2006-08-21  Derek R. Price

        * doc/mkman.pl (do_keyword): Process ref and p?xref differently.
        (Original patch from Kevin R. Bulgrien <address@hidden>.)

Thankss,

Derek
- --
Derek R. Price
CVS Solutions Architect
Get CVS support at Ximbiot <http://ximbiot.com>!
v: +1 248.835.1260
f: +1 248.835.1263
<mailto:address@hidden>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFE6h8nLD1OTBfyMaQRAkepAJ9n8i2zaetWUHJLeQopx+eeQAeGlQCfXfbD
eLmLsaZgbtViSCu7n80b1ms=
=RbWc
-----END PGP SIGNATURE-----
? man-no-see-ref.diff
Index: doc/ChangeLog
===================================================================
RCS file: /cvsroot/cvs/ccvs/doc/ChangeLog,v
retrieving revision 1.721.2.124
diff -u -p -r1.721.2.124 ChangeLog
--- doc/ChangeLog       12 Aug 2006 03:02:36 -0000      1.721.2.124
+++ doc/ChangeLog       21 Aug 2006 20:50:56 -0000
@@ -1,3 +1,8 @@
+2006-08-21  Derek Price  <address@hidden>
+
+       * mkman.pl (do_keyword): Process ref and p?xref differently.
+       (Original patch from Kevin R. Bulgrien <address@hidden>.)
+
 2006-08-11  Mark D. Baushke  <address@hidden>
 
        * cvs.texinfo, cvsclient.texi: Fix some typos.
Index: doc/mkman.pl
===================================================================
RCS file: /cvsroot/cvs/ccvs/doc/mkman.pl,v
retrieving revision 1.1.2.2
diff -u -p -r1.1.2.2 mkman.pl
--- doc/mkman.pl        28 Apr 2005 20:12:19 -0000      1.1.2.2
+++ doc/mkman.pl        21 Aug 2006 20:50:56 -0000
@@ -2,7 +2,8 @@
 #
 # Generate a man page from sections of a Texinfo manual.
 #
-# Copyright 2004 The Free Software Foundation,
+# Copyright 2004, 2006
+#                The Free Software Foundation,
 #                Derek R. Price,
 #                & Ximbiot <http://ximbiot.com>
 #
@@ -72,8 +73,10 @@ sub do_keyword
 {
        my ($file, $parent, $keyword, $content) = @_;
 
-       return "see node \`$content\\(aq in the CVS manual"
-               if $keyword =~ /^(p?x)?ref$/;
+       return "`$content\\(aq in the CVS manual"
+               if $keyword eq "ref";
+       return "see node `$content\\(aq in the CVS manual"
+               if $keyword =~ /^p?xref$/;
        return "\\fP\\fP$content"
                if $keyword =~ /^splitrcskeyword$/;
 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]