bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: CVS, Cygwin and 'long long'


From: Derek R. Price
Subject: Re: CVS, Cygwin and 'long long'
Date: Wed, 07 Jun 2006 14:44:15 -0400
User-agent: Thunderbird 1.5.0.4 (Windows/20060516)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jim Hyslop wrote:
> Currently, the function strto_file_size in src/client.c in the
> trunk revision calls strtoimax.

Actually, it calls strtoumax.

> This causes problems with the Windows build, trying to use a 'long
> long' declaration. Does anyone see any problems with reverting the
> call to strtoul(), as it does in the 1.11 branch?

I doubt reverting this would cause immediate problems, but can we try
to diagnose the current problem completely first?  The GNULIB
replacement strto{i,u}max module should not be using long long if long
long is broken (it should degrade gracefully to using long) and, if
the replacement module is not being used, then Cygwin should not be
defining values for uintmax_t and strtoumax() that don't work
according to POSIX standards

There is also a reasonably solid argument for using strtoumax here, if
possible, since differing platforms may not agree on what the largest
reasonable file size is and parsing correctly anything that looks like
a number allows for slightly more graceful failure cases.

Regards,

Derek
- --
Derek R. Price
CVS Solutions Architect
Get CVS support at Ximbiot <http://ximbiot.com>!
v: +1 248.835.1260
f: +1 248.835.1263
<mailto:address@hidden>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEhx5+LD1OTBfyMaQRAiY7AKCvMpK+cVkd6KrGBslPskwIVoVghgCg3OQU
o+KIkUfp3DUZlBNd/l2rMYQ=
=VU9W
-----END PGP SIGNATURE-----






reply via email to

[Prev in Thread] Current Thread [Next in Thread]