bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gnulib] wait-process module


From: Derek R. Price
Subject: Re: [bug-gnulib] wait-process module
Date: Wed, 26 Apr 2006 11:55:49 -0400
User-agent: Thunderbird 1.5 (X11/20060313)

Bruno Haible wrote:

> This is not an acceptable way of working together. The 'wait-process' module
> in under my responsibility, as you can see from the modules/wait-process file.
> We discussed the patch, and the last thing I said about that patch was that
> I was opposed to it. Your reply was not convincing.
> 
> Please undo your commit. Then we can discuss the patch again. You have seen a 
> lot
> of code in a year, I have seen a lot of code in a year too, maybe we can get
> closer to an agreement this time. But simply committing a patch that was 
> already
> rejected is not acceptable.

I apologize for the misunderstanding.  You hadn't replied to new points
raised by three different people and in general the process on GNULIB
has seemed to me to be that no response meant approval on this list,
generally after about a week.  It's now been over a year.

Anyhow, I understood that your main objection to this patch is that this
is not portable to Windows, and it _is_ portable to Windows.  At least
as far as the module is already.  The macros that detect signals (and
these were already present and being used inside the module) simply
always return false under Windows because Windows doesn't catch (or
produce?) the signals.

The new code only allows the caller to know that a signal caused the
child to exit, *when a signal is present*.  I really don't understand
why you think the new code should do something when a signal is not
present.  Please, fill me in if I have misunderstood.

Would the addition of documentation that mentioned that signals are not
detected (and therefore never returned) under Windows and why make the
patch more palatable for you?

Regards,

Derek
-- 
Derek R. Price
CVS Solutions Architect
Ximbiot <http://ximbiot.com>
v: +1 248.835.1260
f: +1 248.835.1263
<address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]