bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: C99 strto* protos


From: Derek R. Price
Subject: Re: C99 strto* protos
Date: Wed, 19 Apr 2006 15:54:03 -0400
User-agent: Thunderbird 1.5 (X11/20060313)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Eric Blake wrote:

> Grammar, fix by s/only to/just/.

Done, mostly - I changed s/only to/only/ and installed it.

> +++ m4/_inttypes_h.m4 11 Apr 2006 14:27:29 -0000
> @@ -0,0 +1,13 @@
> +# _inttypes_h.m4 serial 1
> 
> Why does this file need a leading underscore in its name?  Nothing else in
> the m4 directory has one.

Because there is already an inttypes_h.m4 (and an inttypes.m4 & and
inttypes-pri.m4).  As I mentioned previously, merging _inttypes_h.m4
with inttypes_h.m4 and inttypes.m4 should be trivial (though it appears
that merging inttypes.m4 is going to require changes to the original in
gettext and thus may require more discussion), but I wanted to put this
off until a second patch for simplicity's sake.

> Do we want "" or <> quoting for FULL_PATH_*_H?  Probably <>, so the
> documentation is wrong.

If you say so.  I wasn't sure about the rules here.  <> is fine by me, I
wasn't sure it was appropriate for even a system header once the full
path had been substituted, but right now the documentation matches what
actually happens.

Looking over the C89 spec, I don't see why <> won't work (there are an
awful lot of "implementation defined"s in there, but <> should be okay,
AFAIKACT), so I've installed a fix for both.

> AC_DEFINE_UNQUOTED([FULL_PATH_]m4_quote(translit(m4_defn([gl_HEADER_NAME]),
> +
> [-./abcdefghijklmnopqrstuvwxyz],
> 
> Should we make this rely on $as_cr_letters and friends, to make this shorter?

Kinda.  I thought about something like this, but I don't want to depend
directly on $as_cr_letters since gl_HEADER_NAME should be known while
autoconf is running and so there is no need to delay its conversion to a
valid CPP macro name until sed can get a crack at it (while configure is
running).  You gave me the clue I needed to find the AS_TR_CPP macro
though, which I have installed to shorten the above a bit.

Regards,

Derek
- --
Derek R. Price
CVS Solutions Architect
Ximbiot <http://ximbiot.com>
v: +1 248.835.1260
f: +1 248.835.1263
<address@hidden>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFERpVbLD1OTBfyMaQRAs3IAKDST1z655XRucKfTKPVUSig44kNBgCg9c9r
tnee38/SvKcXnuhh6uOHI5w=
=uqXB
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]