bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Cvs-cvs] ccvs/contrib ChangeLog validate_repo.in


From: Derek Price
Subject: Re: [Cvs-cvs] ccvs/contrib ChangeLog validate_repo.in
Date: Mon, 03 Oct 2005 17:21:12 -0400
User-agent: Mozilla Thunderbird 1.0.7 (Windows/20050923)

Glancing at the diff
<http://savannah.gnu.org/cgi-bin/viewcvs/cvs/ccvs/contrib/validate_repo.in.diff?tr1=1.7&tr2=1.8&r1=text&r2=text>,
 
I am fairly certain that:

if (my ( $date, $author, $state ) =
    $line =~ /^date: (\S+ \S+( \S+)?);  author: ([^;]+);  state: (\S+);/ )

Needs to be:

if (my ( $date, $tz, $author, $state ) =
    $line =~ /^date: (\S+ \S+( \S+)?);  author: ([^;]+);  state: (\S+);/ )

$tz can thereafter be ignored as its contents will appear again in
$date, but without this, $author will be empty or have the timezone info
and $state will always have the author.  A demonstration:

$ cat tmp.pl
my $s = "abcdefgh";
my ($a, $b, $c, $d) = $s =~ /(ab(c)?)(def)(g)/;
print "a = $a\n";
print "b = $b\n";
print "c = $c\n";
print "d = $d\n";
$ perl tmp.pl
a = abc
b = c
c = def
d = g
$


Regards,

Derek


Larry Jones wrote:

>CVSROOT:       /cvsroot/cvs
>Module name:   ccvs
>Branch:        
>Changes by:    Larry Jones <address@hidden>    05/10/03 20:51:08
>
>Modified files:
>       contrib        : ChangeLog validate_repo.in 
>
>Log message:
>       * validate_repo.in (get_history): Compensate for timezone info in
>       cvs log output.
>
>CVSWeb URLs:
>http://savannah.gnu.org/cgi-bin/viewcvs/cvs/ccvs/contrib/ChangeLog.diff?tr1=1.165&tr2=1.166&r1=text&r2=text
>http://savannah.gnu.org/cgi-bin/viewcvs/cvs/ccvs/contrib/validate_repo.in.diff?tr1=1.7&tr2=1.8&r1=text&r2=text
>
>
>
>_______________________________________________
>Cvs-cvs mailing list
>address@hidden
>http://lists.nongnu.org/mailman/listinfo/cvs-cvs
>  
>


-- 
Derek R. Price
CVS Solutions Architect
Ximbiot <http://ximbiot.com>
v: +1 717.579.6168
f: +1 717.234.3125
<mailto:address@hidden>






reply via email to

[Prev in Thread] Current Thread [Next in Thread]