Re: Feature request/ideas - final patch

[Derek Price]

Derek Price wrote:

> Frank Hemer wrote:
>
> | I have finally finished my patch, tests and alike are contained:
>
>
> I've checked this in on the "newtags" branch in the main repository
> and started with some simplification and cleanup.  If you are going to
> do any further work on this, please work and create patches from there
> to ease merging difficulties.


Frank,

I've committed a few new changes and the tests are passing again, 
including your new tag-ext tests.

My take so far is that your code could be much cleaner and simpler with 
a little more work.  It also needs a lot more comments.  Please take a 
look at what I did to RCS_getprevious, RCS_getorigin, & translate_tag as 
examples and see what you can do.

Also, please remove the special casing for .trunk in all files and 
functions but src/rcs.c (translate_tag), as I did for admin.c.  It 
should not be necessary.

I also added a FIXME comment or two.  Please take a look, especially at 
the one in RCS_getprevious.

I've spotted several errors and omissions so far and have cause to 
wonder if the only reason tag-ext passes currently is that testing is 
not complete.  Please see what you can do about adding more tests.

Regards,

Derek