Re: sanity.sh find_tool() revisions

[Mark D. Baushke]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Derek Robert Price <derek@ximbiot.com> writes:

> So far so good here.  I haven't tried this version yet, but your first
> version appears to work on Fedora and is about half-way through `make
> check' on NetBSD here.  If your new version is mostly the same I don't
> expect problems, but I'll run it anyhow.

Here are the checks I have run it thru myself:

  Machine (cpu)               localcheck   remotecheck   proxycheck
  AIX 4.3 (powerpc)            passed      passed        passed<*>
  FreeBSD 4.2-RELEASE (i386)   passed      passed        passed
  MacOS X - 10.2.8 (PoewrBook) passed      passed        passed
  NetBSD 1.6.1 (i386)          passed      passed        passed
  Redhat 7.3 GNU/Linux (i386)  passed      passed        passed
  Solaris 7 (sparc)            passed      passed        passed
  Solaris 8 (sparc)            passed      passed        passed
  Solaris 9 (sparc)            passed      passed        passed

<*> The AIX 4.3 box passed all tests, but after devcom3 it triggers the
"Found cvs-serv* directories in $TMPDIR." failure. I get the same
problem for unmodified sanity.sh, so this is probably not a problem with
the sanity.sh script itself.

fwiw: I am also getting a 'make check' failure on MacOS X 10.2.8
(PowerBookG4) in the lib directory due to a problem with the
test-getdate.sh expected results.

        -- Mark

For those interested in the difference between the first and final
patches...

 --- sanity.sh  Fri Nov  5 09:16:59 2004
 +++ sanity.sh  Mon Nov  8 11:35:22 2004
 @@ -715,13 +715,13 @@
    if RES=`$vercmd --version </dev/null 2>/dev/null`; then
      if test "X$RES" != "X--version" && test "X$RES" != "X" ; then
        echo "$RES"
 -      return 0
      else
        echo "$RES"
        echo "The command \`$vercmd' does not support the --version option."
      fi
    fi
 -  return 1
 +  # It does not really matter that --version is not supported
 +  return 0
  }
  
  # Try to find a tool that satisfies all of the tests.
 @@ -734,6 +734,8 @@
    cmds="`IFS=:; echo $1`"; shift; tooltests="${1+$@}"
    if test -z "$tooltests"; then tooltests=version_test; fi
    clist=; for cmd in $cmds; do clist="$clist `Which -a $cmd`"; done
 +  # Make sure the default tool is just the first real command name
 +  for default_TOOL in $clist `IFS=:; echo $default_TOOL`; do break; done
    TOOL=""
    for trytool in $clist ; do
      pass=:
 @@ -761,8 +763,6 @@
        return 0
      fi
    done
 -  # Make surethe default tool is just the first command name
 -  for default_TOOL in `IFS=:; echo $default_TOOL`; do break; done
    if test -n "$TOOL"; then
      echo "Notice: The default version of \`$default_TOOL' is defective." 
>>$LOGFILE
      echo "using \`$TOOL' and hoping for the best." >>$LOGFILE
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)

iD8DBQFBj9K73x41pRYZE/gRAgVeAKC8lmYW2XNc6UdyFAVHoAaBkVpQGQCfc5Cr
90+VBIT2UevPczOrorQ6PGU=
=caML
-----END PGP SIGNATURE-----