bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: cvs add (resurrect) incompatibilities


From: Derek Robert Price
Subject: Re: cvs add (resurrect) incompatibilities
Date: Thu, 21 Oct 2004 14:52:51 -0400
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040616

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Mark D. Baushke wrote:

>  2004-10-21  Mark D. Baushke  <address@hidden>
>  
>      * add.c (add): Pay attention to cvswrite mode when resurrecting a
>      file.
>      (Report from Frank Hemer <address@hidden>.)
>      * sanity.sh (resurrection): Add new tests to deal with read-only
>      mode on a cvs add durring a resurrection.


I disagree with this patch.  The file shouldn't be marked read-only
until after commit - it's a modified file and should be in a state the
user can still edit until commit.  Of course, it should be checked out
read-only if other criteria would have caused that on up/co when the
resurrection is of an uncommitted removal (since the resurrected file
immediately assumes "unmodified" and "unedited" status), but not when
the resurrection still needs to be committed as in the case you appear
to be testing.
 
Cheers,

Derek
- --
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFBeAWDLD1OTBfyMaQRAug+AKC/jxTueFTseo9NaDOwvyLNYrRkwwCeIoEv
RWFHfTFLoZLxpf2L54j0VrE=
=YXjH
-----END PGP SIGNATURE-----





reply via email to

[Prev in Thread] Current Thread [Next in Thread]