bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

feature sanity.sh failure on OpenBSD 3.5 sparc64


From: Alexander Taler
Subject: feature sanity.sh failure on OpenBSD 3.5 sparc64
Date: Sat, 09 Oct 2004 18:18:36 -0400

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

OpenBSD 3.5 getopt emits the actual command name, not argv[0],
and the message "unknown option", not "invalid option".  This
causes test basicb-21 to fail on feature.

To correct the problem I used the silly additional argument
workaround to dotest_fail, when I would have preferred to use a
regexp with |.  This will be a problem if any other system turns
up that emits another message.  Perhaps removing the whole test
would be preferable, is it really useful?

Alex

Index: src/sanity.sh
===================================================================
RCS file: /cvs/ccvs/src/sanity.sh,v
retrieving revision 1.980
diff -u -r1.980 sanity.sh
- --- src/sanity.sh       6 Oct 2004 18:53:10 -0000       1.980
+++ src/sanity.sh       9 Oct 2004 22:18:50 -0000
@@ -2963,8 +2963,12 @@
          # of the moon (weirdness with optind), and who knows what else.
          # I've been seeing "illegal"...
          # And I switched it to "invalid". -DRP
+         # OpenBSD 3.5 sparc64 emits "unknown".  This test seems rather
+         # problematic, perhaps it should just be removed.
          dotest_fail basicb-21 "${testcvs} -q admin -H" \
 "admin: invalid option -- H
+${CPROG} \[admin aborted\]: specify ${CPROG} -H admin for usage information" \
+"cvs: unknown option -- H
 ${CPROG} \[admin aborted\]: specify ${CPROG} -H admin for usage information"
          cd ..
          rmdir 1
Index: src/ChangeLog
===================================================================
RCS file: /cvs/ccvs/src/ChangeLog,v
retrieving revision 1.2960
diff -u -r1.2960 ChangeLog
- --- src/ChangeLog       8 Oct 2004 19:45:19 -0000       1.2960
+++ src/ChangeLog       9 Oct 2004 22:18:56 -0000
@@ -1,3 +1,9 @@
+2004-10-09
+
+       * sanity.sh: New possible output for basicb-21.  OpenBSD 3.5
+       getopt emits the command name, not argv[0], and "unknown option".
+       (Patch from Alexander Taler <address@hidden>.)
+
 2004-10-08  Derek Price  <address@hidden>
 
        * client.c (send_args): Carry through a const to silence gcc -Wall.


- -- 
http://libcvs.cvshome.org/    Access CVS through a library. 
PGP:  ID: 0x23DC453B  FPR: 42D0 66C2 9FF8 553A 373A  B819 4C34 93BA 23DC 453B
The purpose of the minutes is not to record events, it is to protect people.
                -- Sir Humphrey Appleby
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (OpenBSD)
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/>

iD8DBQFBaGOYTDSTuiPcRTsRAvtTAJ99EpUi/yEhs4LU5nDFS6b6ne7lxQCfU3yL
vGjczM98zPuHByZY774G0BU=
=4Gow
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]