bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: CVS update [cvs1-11-x-branch]: /ccvs/src/


From: Derek Robert Price
Subject: Re: CVS update [cvs1-11-x-branch]: /ccvs/src/
Date: Wed, 01 Sep 2004 15:54:15 -0400
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040616

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Just another thought.  SSH's behavior may very well be "rude" but,
even if they fix the problem on their end, there is nothing stopping
some other program (PuTTY, commercial SSH clients, whatever) from
doing the same thing.  Perhaps having a substitute for the stdio
routines is still the best preventative measure for this sort of problem.

The alternative would seem to be a fix at the OS level to prevent
stdout & stderr from being set nonblock, which I an reluctant to
believe could happen, if it is really even desirable on that level.

Cheers,

Derek

Larry Jones wrote:

>Derek Robert Price writes:
>
>>What about the case in question, when output is redirected, piped, and
>>some other program sets O_NONBLOCK?  Ideally, stdio would handle this,
>>but it currently does not.
>
>
>I've changed my mind, we shouldn't change CVS at all.
>
>Nonblocking files do not behave the way files are supposed to, so they
>should only be used in carefully controlled situations (basically, when
>you're guaranteed to have exclusive usage of the file).  By setting one
>of its standard files into nonblocking mode, SSH is being extremely
>antisocial since the file might well be shared with a completely
>unrelated application which the nonblocking mode will seriously
>jeopardize (viz CVS, but other applications have the same problem).
>Thus, the SSH folks should be severely beaten (metaphorically, of
>course) until they agree to fix their code.  I understand what they're
>trying to accomplish, but they're going about it in the wrong way --
>they should be testing for writability with select before trying to
>write to stderr rather than just blindly putting stderr into nonblocking
>mode and expecting everyone else to just cope with it.
>
>-Larry Jones
>
>We don't ATTEND parties, we just CRASH 'em. -- Calvin
>
>
>_______________________________________________
>Bug-cvs mailing list
>address@hidden
>http://lists.gnu.org/mailman/listinfo/bug-cvs



- --
                *8^)

Email: address@hidden

Get CVS support at <http://ximbiot.com>!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFBNijmLD1OTBfyMaQRAp3KAJ9IEKkPKw3SAzERRHMoSVf1iPi67QCg3KaM
f49T7j46oui2iMWUh0IOJww=
=M8mk
-----END PGP SIGNATURE-----





reply via email to

[Prev in Thread] Current Thread [Next in Thread]